Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(order/category/Lattice): The category of lattices #11968

Closed
wants to merge 4 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Define Lattice, the category of lattices with lattice homs.


Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Feb 11, 2022
Copy link
Collaborator

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a TODO, you could make the functor Lattice => BoundedLattice which adds bounds by with_top (with_bot X) and show its adjunction relations. Please don't include that in this PR though.

I want to check with @Vierkantor that the new instances in order/hom/lattice make sense, otherwise lgtm!

bors d=Vierkantor

src/order/category/Lattice.lean Outdated Show resolved Hide resolved
src/order/category/Lattice.lean Show resolved Hide resolved
src/order/category/Lattice.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Feb 11, 2022

✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Feb 11, 2022
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instances look good to me!

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Feb 15, 2022
bors bot pushed a commit that referenced this pull request Feb 15, 2022
Define `Lattice`, the category of lattices with lattice homs.
@bors
Copy link

bors bot commented Feb 15, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/category/Lattice): The category of lattices [Merged by Bors] - feat(order/category/Lattice): The category of lattices Feb 15, 2022
@bors bors bot closed this Feb 15, 2022
@bors bors bot deleted the Lattice branch February 15, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants