Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(data/finset/basic): Golf and compress #11987

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(data/finset/basic): Golf and compress #11987

wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

  • Move the lattice instance earlier so that it can be used to prove lemmas
  • Golf proofs
  • Compress statements within the style guidelines

This is the grown out of proportions no novelty part of #11982.

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Feb 12, 2022
@YaelDillies YaelDillies mentioned this pull request Feb 12, 2022
Closed
1 task
bryangingechen
bryangingechen approved these changes Feb 12, 2022
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

eric-wieser
eric-wieser approved these changes Feb 12, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm not really sure this was a good use of your time, but I'd much rather see it in a separate PR like this than mixed in with another one.

A couple minor comments above about section headings and pi vs forall.

bors d+

@bors
Copy link

bors bot commented Feb 12, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Feb 12, 2022
@YaelDillies @eric-wieser
restore section
1f8bc82 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@YaelDillies
Copy link
Collaborator Author

Don't worry. It didn't take me too long.

bors merge

bors bot pushed a commit that referenced this pull request Feb 12, 2022
@YaelDillies
chore(data/finset/basic): Golf and compress (#11987)
4a4a3a9 
* Move the `lattice` instance earlier so that it can be used to prove lemmas
* Golf proofs
* Compress statements within the style guidelines
@bors
Copy link

bors bot commented Feb 12, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/finset/basic): Golf and compress [Merged by Bors] - chore(data/finset/basic): Golf and compress Feb 12, 2022
@bors bors bot closed this Feb 12, 2022
@bors bors bot deleted the finset_golf branch February 12, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@bryangingechen bryangingechen bryangingechen approved these changes

@b-mehta b-mehta Awaiting requested review from b-mehta

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YaelDillies @eric-wieser @bryangingechen @leanprover-community-bot-assistant