Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(measure_theory/integral/lebesgue): use to_additive when declaring instances and basic lemmas about simple functions #12000

Closed
wants to merge 1 commit into from

Conversation

RemyDegenne
Copy link
Collaborator

I also grouped similar lemmas together and added one or two missing ones.


Open in Gitpod

@RemyDegenne RemyDegenne added the awaiting-review The author would like community review of the PR label Feb 12, 2022
@RemyDegenne RemyDegenne changed the title chore(measure_theory/integral/lebesgue): use to_additive when declaring instances and basic lemmas chore(measure_theory/integral/lebesgue): use to_additive when declaring instances and basic lemmas about simple functions Feb 12, 2022
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

bors d+

@bors
Copy link

bors bot commented Feb 12, 2022

✌️ RemyDegenne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Feb 12, 2022
Comment on lines +365 to +366
@[to_additive] instance [monoid β] : monoid (α →ₛ β) :=
function.injective.monoid (λ f, show α → β, from f) coe_injective coe_one coe_mul
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be wise to use function.injective.monoid_pow here eventually to avoid diamonds, but that's only in scope for this PR if you want it to be.

@RemyDegenne
Copy link
Collaborator Author

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Feb 12, 2022
bors bot pushed a commit that referenced this pull request Feb 12, 2022
…ng instances and basic lemmas about simple functions (#12000)

I also grouped similar lemmas together and added one or two missing ones.
@bors
Copy link

bors bot commented Feb 12, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(measure_theory/integral/lebesgue): use to_additive when declaring instances and basic lemmas about simple functions [Merged by Bors] - chore(measure_theory/integral/lebesgue): use to_additive when declaring instances and basic lemmas about simple functions Feb 12, 2022
@bors bors bot closed this Feb 12, 2022
@bors bors bot deleted the simple_func_to_additive branch February 12, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants