Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/module/torsion): define torsion submodules #12027

Closed
wants to merge 24 commits into from

Conversation

pbazin
Copy link
Collaborator

@pbazin pbazin commented Feb 14, 2022

This file defines the a-torsion and torsion submodules for a R-module M and gives some basic properties. (The ultimate goal I'm working on is to classify the finitely-generated modules over a PID).


Open in Gitpod

@eric-wieser eric-wieser added the awaiting-author A reviewer has asked the author a question or requested changes label Feb 14, 2022
@pbazin pbazin added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 14, 2022
@ocfnash ocfnash added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 28, 2022
@pbazin pbazin added the awaiting-review The author would like community review of the PR label Mar 17, 2022
@riccardobrasca
Copy link
Member

Thanks!

bors d+

@bors
Copy link

bors bot commented Mar 17, 2022

✌️ pbazin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Mar 17, 2022
@pbazin
Copy link
Collaborator Author

pbazin commented Mar 17, 2022

bors r+

1 similar comment
@pbazin
Copy link
Collaborator Author

pbazin commented Mar 17, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 17, 2022
This file defines the a-torsion and torsion submodules for a R-module M and gives some basic properties. (The ultimate goal I'm working on is to classify the finitely-generated modules over a PID).
@bors
Copy link

bors bot commented Mar 17, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Mar 17, 2022
This file defines the a-torsion and torsion submodules for a R-module M and gives some basic properties. (The ultimate goal I'm working on is to classify the finitely-generated modules over a PID).
@bors
Copy link

bors bot commented Mar 17, 2022

Build failed:

@riccardobrasca
Copy link
Member

You probably need to merge master and see what has changed.

@pbazin
Copy link
Collaborator Author

pbazin commented Mar 23, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 23, 2022
This file defines the a-torsion and torsion submodules for a R-module M and gives some basic properties. (The ultimate goal I'm working on is to classify the finitely-generated modules over a PID).
@bors
Copy link

bors bot commented Mar 23, 2022

Build failed (retrying...):

@fpvandoorn
Copy link
Member

bors r-
bors d+

it seems that this PR causes an error

@bors
Copy link

bors bot commented Mar 23, 2022

✌️ pbazin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bors
Copy link

bors bot commented Mar 23, 2022

Canceled.

@riccardobrasca
Copy link
Member

There is the following error

/home/lean/actions-runner/_work/mathlib/mathlib/src/algebra/module/torsion.lean:138:28: context: switched to simple application elaboration procedure because failed to use expected type to elaborate it, error message
  type mismatch at application
    function.surjective.module_left ?m_9 ideal.quotient.mk_surjective
  term
    ideal.quotient.mk_surjective
  has type
    function.surjective ⇑(ideal.quotient.mk ?m_3)
  but is expected to have type
    function.surjective ⇑?m_5

Please fix it before merging the PR. Thanks!

@pbazin
Copy link
Collaborator Author

pbazin commented Mar 24, 2022

I couldn't reproduce the error locally and merging master didn't work but now it's fixed... but I still have no idea why it wasn't able to infer the implicit arguments

@pbazin
Copy link
Collaborator Author

pbazin commented Mar 24, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 24, 2022
This file defines the a-torsion and torsion submodules for a R-module M and gives some basic properties. (The ultimate goal I'm working on is to classify the finitely-generated modules over a PID).



Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
@bors
Copy link

bors bot commented Mar 24, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/module/torsion): define torsion submodules [Merged by Bors] - feat(algebra/module/torsion): define torsion submodules Mar 24, 2022
@bors bors bot closed this Mar 24, 2022
@bors bors bot deleted the pid_fg_module_classification1 branch March 24, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants