New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor(topology/algebra): reorder imports #12089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
The author would like community review of the PR
awaiting-CI
The author would like to see what CI has to say before doing more work.
labels
Feb 16, 2022
github-actions
bot
removed
the
awaiting-CI
The author would like to see what CI has to say before doing more work.
label
Feb 16, 2022
eric-wieser
reviewed
Feb 16, 2022
eric-wieser
force-pushed
the
YK-top-monoid-reorder
branch
from
February 18, 2022 11:04
8cd937b
to
8659885
Compare
eric-wieser
reviewed
Feb 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
I pushed a tiny relaxation to a typeclass, but I'm pretty confident it won't break the build
leanprover-community-bot-assistant
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Feb 18, 2022
bors bot
pushed a commit
that referenced
this pull request
Feb 18, 2022
* move `mul_opposite.topological_space` and `units.topological_space` to a new file; * import `mul_action` in `monoid`, not vice versa. With this order of imports, we can reuse results about `has_continuous_smul` in lemmas about topological monoids. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
refactor(topology/algebra): reorder imports
[Merged by Bors] - refactor(topology/algebra): reorder imports
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mul_opposite.topological_space
andunits.topological_space
to a new file;mul_action
inmonoid
, not vice versa.With this order of imports, we can reuse results about
has_continuous_smul
in lemmas about topological monoids.