Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(topology/algebra): reorder imports #12089

Closed
wants to merge 8 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 16, 2022

  • move mul_opposite.topological_space and units.topological_space to a new file;
  • import mul_action in monoid, not vice versa.

With this order of imports, we can reuse results about has_continuous_smul in lemmas about topological monoids.


Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Feb 16, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 16, 2022
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

I pushed a tiny relaxation to a typeclass, but I'm pretty confident it won't break the build

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 18, 2022
bors bot pushed a commit that referenced this pull request Feb 18, 2022
* move `mul_opposite.topological_space` and `units.topological_space` to a new file;
* import `mul_action` in `monoid`, not vice versa.

With this order of imports, we can reuse results about `has_continuous_smul` in lemmas about topological monoids.



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Feb 18, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(topology/algebra): reorder imports [Merged by Bors] - refactor(topology/algebra): reorder imports Feb 18, 2022
@bors bors bot closed this Feb 18, 2022
@bors bors bot deleted the YK-top-monoid-reorder branch February 18, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants