New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(algebra/group/{hom,prod}): has_mul and mul_hom.prod #12110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ported from similar for monoid_hom
Ported over from monoid_hom.prod
pechersky
added
awaiting-CI
The author would like to see what CI has to say before doing more work.
awaiting-review
The author would like community review of the PR
labels
Feb 18, 2022
3 tasks
github-actions
bot
removed
the
awaiting-CI
The author would like to see what CI has to say before doing more work.
label
Feb 18, 2022
eric-wieser
reviewed
Feb 18, 2022
urkud
reviewed
Feb 22, 2022
urkud
reviewed
Feb 22, 2022
Otherwise LGTM. |
✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
The PR author may merge after reviewing final suggestions.
and removed
awaiting-review
The author would like community review of the PR
labels
Feb 22, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 22, 2022
Ported over from `monoid_hom`.
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(algebra/group/{hom,prod}): has_mul and mul_hom.prod
[Merged by Bors] - feat(algebra/group/{hom,prod}): has_mul and mul_hom.prod
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported over from
monoid_hom
.