[Merged by Bors] - feat(linear_algebra/annihilating_polynomial): add definition of annihilating ideal and show minpoly generates in field case #12140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbuzzard
reviewed
Feb 19, 2022
eric-wieser
reviewed
Feb 19, 2022
eric-wieser
changed the title
eric-wieser
reviewed
Feb 19, 2022
eric-wieser
reviewed
Feb 19, 2022
eric-wieser
reviewed
Feb 19, 2022
eric-wieser
reviewed
Feb 19, 2022
eric-wieser
reviewed
Feb 19, 2022
twoquarterrican
added
the
awaiting-review
eric-wieser
reviewed
Feb 21, 2022
eric-wieser
reviewed
Feb 21, 2022
eric-wieser
reviewed
Feb 21, 2022
eric-wieser
reviewed
Feb 22, 2022
eric-wieser
reviewed
Feb 22, 2022
|
@eric-wieser just following up. Anything else needed on this? |
ericrbg
reviewed
Mar 1, 2022
ericrbg
added
awaiting-author
leanprover-community-bot-assistant
added
the
merge-conflict
twoquarterrican
force-pushed
the
annihilating_ideal
branch
from
14a096c
to
f511cb2
Compare
leanprover-community-bot-assistant
removed
the
merge-conflict
twoquarterrican
added
awaiting-review
twoquarterrican
added
awaiting-author
twoquarterrican
force-pushed
the
annihilating_ideal
branch
from
4ecd8aa
to
ca686aa
Compare
twoquarterrican
added
awaiting-review
|
Can you please merge master to see if this still works? |
Vierkantor
reviewed
Jul 11, 2022
There was a problem hiding this comment.
Sorry for the wait, I only just got time to get around to all the reviews. There are still some (relatively minor) comments in annihilating_polynomial.lean that you haven't addressed. Could you merge master and address them?
Vierkantor
added
awaiting-author
Vierkantor
reviewed
Jul 22, 2022
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 22, 2022
…ilating ideal and show minpoly generates in field case (#12140) adding item from trivial undergrad subjects list Co-authored-by: Patrick Massot <patrickmassot@free.fr> Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com> Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jul 22, 2022
…ilating ideal and show minpoly generates in field case (#12140) adding item from trivial undergrad subjects list Co-authored-by: Patrick Massot <patrickmassot@free.fr> Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com> Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
|
Build failed: |
|
I think this needs a master merge |
…ilating ideal and show minpoly generates in field case
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com> Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
PatrickMassot
force-pushed
the
annihilating_ideal
branch
from
fc2b45d
to
2a51c00
Compare
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 25, 2022
…ilating ideal and show minpoly generates in field case (#12140) adding item from trivial undergrad subjects list Co-authored-by: Patrick Massot <patrickmassot@free.fr> Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com> Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bottine
pushed a commit
to bottine/mathlib
that referenced
this pull request
Jul 30, 2022
…ilating ideal and show minpoly generates in field case (leanprover-community#12140) adding item from trivial undergrad subjects list Co-authored-by: Patrick Massot <patrickmassot@free.fr> Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com> Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
robertylewis
pushed a commit
that referenced
this pull request
Aug 2, 2022
…ilating ideal and show minpoly generates in field case (#12140) adding item from trivial undergrad subjects list Co-authored-by: Patrick Massot <patrickmassot@free.fr> Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com> Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
khwilson
pushed a commit
that referenced
this pull request
Aug 2, 2022
…ilating ideal and show minpoly generates in field case (#12140) adding item from trivial undergrad subjects list Co-authored-by: Patrick Massot <patrickmassot@free.fr> Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com> Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding item from trivial undergrad subjects list