Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(order/hom/lattice): Finitary join-/meet-preserving maps #12149

Closed
wants to merge 4 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Define sup_bot_hom, inf_top_hom and their associated class.


Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Feb 19, 2022
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fun_like parts look good to me. I'll leave the rest to Bhavik.

Copy link
Collaborator

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 21, 2022
bors bot pushed a commit that referenced this pull request Feb 21, 2022
Define `sup_bot_hom`, `inf_top_hom` and their associated class.
@bors
Copy link

bors bot commented Feb 21, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Feb 21, 2022
Define `sup_bot_hom`, `inf_top_hom` and their associated class.
@bors
Copy link

bors bot commented Feb 21, 2022

Build failed (retrying...):

@bryangingechen
Copy link
Collaborator

I think this is causing the build to fail.
bors r-
bors d+

@bors
Copy link

bors bot commented Feb 21, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bors
Copy link

bors bot commented Feb 21, 2022

Canceled.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Feb 21, 2022
@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Feb 21, 2022
@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Feb 22, 2022
Define `sup_bot_hom`, `inf_top_hom` and their associated class.
@bors
Copy link

bors bot commented Feb 22, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/hom/lattice): Finitary join-/meet-preserving maps [Merged by Bors] - feat(order/hom/lattice): Finitary join-/meet-preserving maps Feb 22, 2022
@bors bors bot closed this Feb 22, 2022
@bors bors bot deleted the sup_bot_hom branch February 22, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants