Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/*): Missing order lifting instances #12154

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(order/*): Missing order lifting instances #12154

wants to merge 3 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Add a few missing pullbacks of order instances.

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Feb 19, 2022
jcommelin
jcommelin reviewed Feb 21, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@bors
Copy link

bors bot commented Feb 21, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes label Feb 21, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Feb 21, 2022
@YaelDillies @eric-wieser
comment on bounded_order.lift
b6cb1cb 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Feb 21, 2022
@YaelDillies
feat(order/*): Missing order lifting instances (#12154)
634dfc8 
Add a few missing pullbacks of order instances.
@bors
Copy link

bors bot commented Feb 21, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/*): Missing order lifting instances [Merged by Bors] - feat(order/*): Missing order lifting instances Feb 21, 2022
@bors bors bot closed this Feb 21, 2022
@bors bors bot deleted the order_lifts branch February 21, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@pechersky pechersky pechersky left review comments

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YaelDillies @eric-wieser @pechersky @jcommelin @leanprover-community-bot-assistant