Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(*): move normed field lemmas into root namespace #12163

Closed
wants to merge 4 commits into from

Conversation

j-loreaux
Copy link
Collaborator

@j-loreaux j-loreaux commented Feb 20, 2022

This takes the normed field lemmas given in analysis.normed_space.basic and moves them from the normed_field namespace into the root namespace.

This PR moves these lemmas and definitions: norm_mul, nnnorm_mul, norm_hom, nnnorm_hom, norm_pow, nnnorm_pow, norm_prod, nnnorm_prod, norm_div, nnnorm_div, norm_inv, nnnorm_inv, norm_zpow, nnnorm_zpow.


Open in Gitpod

@j-loreaux j-loreaux added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Feb 20, 2022
@j-loreaux
Copy link
Collaborator Author

As discussed here on Zulip, these lemmas should be moved to the root namespace. This was originally attempted as part of #12132 which introduces normed division rings and generalized most of these lemmas to that setting, but I ran into build issues. So it was suggested to split it into two PRs.

@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 20, 2022
@urkud
Copy link
Member

urkud commented Feb 20, 2022

Could you please list all theorems that you move to the root ns?

@urkud
Copy link
Member

urkud commented Feb 20, 2022

I'm not sure that exists_norm_lt should go to the root ns. There is a version of this lemma for a non-trivial normed space.

@j-loreaux
Copy link
Collaborator Author

j-loreaux commented Feb 20, 2022

The following are the lemmas moved into the root namespace. I could see moving the instances and the last 6 lemmas back into normed_field. Thoughts? (Edit: updated list. strike out means it is kept in the normed_field namespace.)

norm_mul
to_normed_comm_ring (instance)
to_norm_one_class (instance)
nnnorm_mul
norm_hom
nnnorm_hom
norm_pow
nnnorm_pow
norm_prod
nnnorm_prod
norm_div
nnnorm_div
norm_inv
nnnorm_inv
norm_zpow
nnnorm_zpow
exists_one_lt_norm
exists_norm_lt_one
exists_lt_norm
exists_norm_lt
punctured_nhds_ne_bot
nhds_within_is_unit_ne_bot

@eric-wieser
Copy link
Member

The instances definitely belong inside the namespace

@eric-wieser
Copy link
Member

I'm not sure that exists_norm_lt should go to the root ns. There is a version of this lemma for a non-trivial normed space.

I can't find that lemma - can you give the full name?

@j-loreaux
Copy link
Collaborator Author

I think he intends : normed_space.exists_lt_norm

@eric-wieser
Copy link
Member

Can normed_field.exists_lt_norm be proved with normed_space.exists_lt_norm?

@j-loreaux
Copy link
Collaborator Author

It goes in the reverse direction. You use the field version to prove the normed space version.

@urkud
Copy link
Member

urkud commented Feb 21, 2022

We can have the normed_space versions in the root namespace. Then we either call normed_field.exists... k or exists... k k.

@urkud
Copy link
Member

urkud commented Feb 21, 2022

BTW, I think that we should have exists_lt_norm (r : real) (...) : ∃ c : k, r < norm c, not exists_one_lt_norm.

@j-loreaux
Copy link
Collaborator Author

j-loreaux commented Feb 21, 2022

@urkud normed_space.exists_lt_norm is the only normed space version we have (I think). Are you saying you want me to add more versions corresponding to the normed_field ones?

@urkud
Copy link
Member

urkud commented Feb 21, 2022

I think that for now, you can just leave these lemmas in the normed_field NS.

@urkud
Copy link
Member

urkud commented Feb 21, 2022

Thanks!
bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 21, 2022
bors bot pushed a commit that referenced this pull request Feb 21, 2022
This takes the normed field lemmas given in `analysis.normed_space.basic` and moves them from the `normed_field` namespace into the root namespace.

This PR moves these lemmas and definitions: `norm_mul`, `nnnorm_mul`, `norm_hom`, `nnnorm_hom`, `norm_pow`, `nnnorm_pow`, `norm_prod`, `nnnorm_prod`, `norm_div`, `nnnorm_div`, `norm_inv`, `nnnorm_inv`, `norm_zpow`, `nnnorm_zpow`.
@bors
Copy link

bors bot commented Feb 21, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(*): move normed field lemmas into root namespace [Merged by Bors] - refactor(*): move normed field lemmas into root namespace Feb 21, 2022
@bors bors bot closed this Feb 21, 2022
@bors bors bot deleted the j-loreaux/move-normed-field-lemmas branch February 21, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants