New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor(*): move normed field lemmas into root namespace #12163
Conversation
As discussed here on Zulip, these lemmas should be moved to the root namespace. This was originally attempted as part of #12132 which introduces normed division rings and generalized most of these lemmas to that setting, but I ran into build issues. So it was suggested to split it into two PRs. |
Could you please list all theorems that you move to the root ns? |
I'm not sure that |
The following are the lemmas moved into the root namespace. I could see moving the instances and the last 6 lemmas back into norm_mul |
The instances definitely belong inside the namespace |
I can't find that lemma - can you give the full name? |
I think he intends : |
Can |
It goes in the reverse direction. You use the field version to prove the normed space version. |
We can have the |
BTW, I think that we should have |
@urkud normed_space.exists_lt_norm is the only normed space version we have (I think). Are you saying you want me to add more versions corresponding to the |
I think that for now, you can just leave these lemmas in the |
Thanks! |
This takes the normed field lemmas given in `analysis.normed_space.basic` and moves them from the `normed_field` namespace into the root namespace. This PR moves these lemmas and definitions: `norm_mul`, `nnnorm_mul`, `norm_hom`, `nnnorm_hom`, `norm_pow`, `nnnorm_pow`, `norm_prod`, `nnnorm_prod`, `norm_div`, `nnnorm_div`, `norm_inv`, `nnnorm_inv`, `norm_zpow`, `nnnorm_zpow`.
Pull request successfully merged into master. Build succeeded: |
This takes the normed field lemmas given in
analysis.normed_space.basic
and moves them from thenormed_field
namespace into the root namespace.This PR moves these lemmas and definitions:
norm_mul
,nnnorm_mul
,norm_hom
,nnnorm_hom
,norm_pow
,nnnorm_pow
,norm_prod
,nnnorm_prod
,norm_div
,nnnorm_div
,norm_inv
,nnnorm_inv
,norm_zpow
,nnnorm_zpow
.