Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/ideal/operations): remove unneeded assumptions from smul_induction_on #12193

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(ring_theory/ideal/operations): remove unneeded assumptions from smul_induction_on #12193

wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

Open in Gitpod

@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Feb 21, 2022
@eric-wieser eric-wieser mentioned this pull request Feb 21, 2022
Closed
Vierkantor
Vierkantor approved these changes Feb 22, 2022
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, although the timeout concerns me.

@Vierkantor Vierkantor added awaiting-author A reviewer has asked the author a question or requested changes awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-review The author would like community review of the PR labels Feb 22, 2022
@eric-wieser
Copy link
Member Author

I think that's unrelated and was fixed in a recent PR. Let's try a merge...

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 22, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 22, 2022
@Vierkantor
Copy link
Collaborator

Thanks for the merge!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 22, 2022
bors bot pushed a commit that referenced this pull request Feb 22, 2022
@eric-wieser
feat(ring_theory/ideal/operations): remove unneeded assumptions from …
79c5de9 
…`smul_induction_on` (#12193)
@bors
Copy link

bors bot commented Feb 22, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/ideal/operations): remove unneeded assumptions from smul_induction_on [Merged by Bors] - feat(ring_theory/ideal/operations): remove unneeded assumptions from smul_induction_on Feb 22, 2022
@bors bors bot closed this Feb 22, 2022
@bors bors bot deleted the eric-wieser/smul_induction_on' branch February 22, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eric-wieser @Vierkantor