Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/quot): primed quotient funcs on mk #12204

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(data/quot): primed quotient funcs on mk #12204

wants to merge 3 commits into from

Conversation

pechersky
Copy link
Collaborator

Open in Gitpod

@pechersky pechersky added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR labels Feb 22, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 22, 2022
ocfnash
ocfnash reviewed Feb 26, 2022
View reviewed changes
src/data/quot.lean Outdated Show resolved Hide resolved
@ocfnash
Copy link
Collaborator

ocfnash commented Feb 26, 2022

One naming suggestions but otherwise this looks good.

bors d+

@bors
Copy link

bors bot commented Feb 26, 2022

✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Feb 26, 2022
@pechersky @ocfnash
Update src/data/quot.lean
0a274e5 
Co-authored-by: Oliver Nash <github@olivernash.org>
@pechersky
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Feb 27, 2022
@pechersky
feat(data/quot): primed quotient funcs on mk (#12204)
906a88b 
Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
@bors
Copy link

bors bot commented Feb 27, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/quot): primed quotient funcs on mk [Merged by Bors] - feat(data/quot): primed quotient funcs on mk Feb 27, 2022
@bors bors bot closed this Feb 27, 2022
@bors bors bot deleted the pechersky/quotient-mk-mk branch February 27, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocfnash ocfnash ocfnash left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pechersky @ocfnash