[Merged by Bors] - chore(ring_theory): split localization.lean and dedekind_domain.lean
#12206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the lines in `localization.lean` are nearly identically available in the other files:
```bash
$ src/ring_theory/localization/*.lean | sort | comm -23 <(sort src/ring_theory/localization.lean) -
Authors: Kenny Lau, Mario Carneiro, Johan Commelin, Amelia Livingston
end
is_domain_localization (le_non_zero_divisors_of_no_zero_divisors
is_domain_of_le_non_zero_divisors K (le_refl (non_zero_divisors A))
* `is_localization.is_integer` is a predicate stating that `x : S` is in the image of `R`
open_locale big_operators
section
variables (A K) (C : Type*)
variables (A) [unique_factorization_monoid A]
variables (K : Type*)
variables (M N)
variables (M) {S}
variables (R)
variables (R) {A : Type*} [comm_ring A] [is_domain A]
variables {R M} (S) {K : Type*}
variables {Rₘ Sₘ}
variables (S Q M)
```
Vierkantor
added
awaiting-review
|
This clearly shouldn't wait in the queue too long. I haven't reviewed it carefully, but here is the |
|
✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
Build just passed, so I'll go ahead and bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Feb 22, 2022
…an` (#12206) These files were rather long and had hundreds-deep dependency graphs. I split them into smaller files with less imports, so that they are easier to build and modify. Proof nothing was lost: ```bash $ cat src/ring_theory/localization/*.lean | sort | comm -23 <(sort src/ring_theory/localization.lean) - | grep -E 'lemma|theorem|def|instance|class' $ cat src/ring_theory/dedekind_domain/*.lean | sort | comm -23 <(sort src/ring_theory/dedekind_domain.lean) - | grep -E 'lemma|theorem|def|instance|class' giving three equivalent definitions (TODO: and shows that they are equivalent). ``` Zulip thread: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Splitting.20.60localization.2Elean.60.20and.20.60dedekind_domain.2Elean
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Feb 22, 2022
…an` (#12206) These files were rather long and had hundreds-deep dependency graphs. I split them into smaller files with less imports, so that they are easier to build and modify. Proof nothing was lost: ```bash $ cat src/ring_theory/localization/*.lean | sort | comm -23 <(sort src/ring_theory/localization.lean) - | grep -E 'lemma|theorem|def|instance|class' $ cat src/ring_theory/dedekind_domain/*.lean | sort | comm -23 <(sort src/ring_theory/dedekind_domain.lean) - | grep -E 'lemma|theorem|def|instance|class' giving three equivalent definitions (TODO: and shows that they are equivalent). ``` Zulip thread: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Splitting.20.60localization.2Elean.60.20and.20.60dedekind_domain.2Elean
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
localization.lean and dedekind_domain.leanlocalization.lean and dedekind_domain.lean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files were rather long and had hundreds-deep dependency graphs. I split them into smaller files with less imports, so that they are easier to build and modify.
Proof nothing was lost:
Zulip thread: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Splitting.20.60localization.2Elean.60.20and.20.60dedekind_domain.2Elean