[Merged by Bors] - feat(ring_theory/witt_vector): Witt vectors are a DVR #12213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
robertylewis
added
the
awaiting-review
robertylewis
changed the title
hrmacbeth
changed the title
|
Can you also update the description? |
|
I've updated the PR description, renamed the file, and done a little reogranizing! |
hrmacbeth
reviewed
Feb 24, 2022
hrmacbeth
reviewed
Feb 24, 2022
riccardobrasca
approved these changes
Feb 24, 2022
Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
robertylewis
commented
Feb 24, 2022
|
All of the private calculational lemmas were really just used for one theorem. I moved them to all be together, renamed them to |
|
LGTM. I think everything above it resolved, but I'll delegate rather than merge so an author can make the final call. bors d+ |
|
✌️ robertylewis can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Feb 27, 2022
This PR adds two connected files. `mul_coeff.lean` adds an auxiliary result that's used in a few places in #12041 . One of these places is in `discrete_valuation_ring.lean`, which shows that Witt vectors over a perfect field form a DVR. Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Rob Lewis <rob.y.lewis@gmail.com> Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two connected files.
mul_coeff.leanadds an auxiliary result that's used in a few places in #12041 . One of these places is indiscrete_valuation_ring.lean, which shows that Witt vectors over a perfect field form a DVR.Co-authored-by: Heather Macbeth 25316162+hrmacbeth@users.noreply.github.com
Co-authored-by: Johan Commelin johan@commelin.net
Branched from #12041