Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(topology/spectral/hom): Spectral maps #12228

Closed
wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Feb 22, 2022

Define spectral maps in three ways:

  • is_spectral_map, the unbundled predicate
  • spectral_map, the bundled type
  • spectral_map_class, the hom class

The design for is_spectral_map matches continuous. The design for spectral_map and spectral_map_class follows the hom refactor.


The plan is to add spectral spaces in topology.spectral.basic and Spectral, the category, in topology.category.Spectral.

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Feb 22, 2022
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fun_like parts look good to me, but I know very little about spectral maps to confirm the definition itself. So let's ask another reviewer.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

variables [topological_space α] [topological_space β] [topological_space γ] {f : α → β} {s : set β}

/-- A function between topological spaces is spectral if it is continuous and the preimage of every
compact open set is compact open. -/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
compact open set is compact open. -/
compact open set is compact. -/

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 25, 2022
bors bot pushed a commit that referenced this pull request Feb 25, 2022
Define spectral maps in three ways:
* `is_spectral_map`, the unbundled predicate
* `spectral_map`, the bundled type
* `spectral_map_class`, the hom class

The design for `is_spectral_map` matches `continuous`. The design for `spectral_map` and `spectral_map_class` follows the hom refactor.
@bors
Copy link

bors bot commented Feb 25, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/spectral/hom): Spectral maps [Merged by Bors] - feat(topology/spectral/hom): Spectral maps Feb 25, 2022
@bors bors bot closed this Feb 25, 2022
@bors bors bot deleted the spectral_map branch February 25, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants