New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(ring_theory/adjoin/basic): if a set of elements of a subobject commute, its closure/adjoin is also commutative #12231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dupuisf
added
awaiting-review
The author would like community review of the PR
awaiting-CI
The author would like to see what CI has to say before doing more work.
labels
Feb 23, 2022
github-actions
bot
removed
the
awaiting-CI
The author would like to see what CI has to say before doing more work.
label
Feb 23, 2022
eric-wieser
reviewed
Feb 23, 2022
dupuisf
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Feb 27, 2022
dupuisf
added
awaiting-review
The author would like community review of the PR
awaiting-CI
The author would like to see what CI has to say before doing more work.
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Mar 4, 2022
dupuisf
changed the title
feat(ring_theory/adjoin/basic): if some elements of an algebra commute, the algebra they generate is commutative
feat(ring_theory/adjoin/basic): if a set of elements of a subobject commute, its closure/adjoin is also commutative
Mar 4, 2022
riccardobrasca
approved these changes
Mar 4, 2022
Thanks! bors d+ |
✌️ dupuisf can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
The PR author may merge after reviewing final suggestions.
and removed
awaiting-review
The author would like community review of the PR
awaiting-CI
The author would like to see what CI has to say before doing more work.
labels
Mar 4, 2022
Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
dupuisf
commented
Mar 4, 2022
bors r+ |
github-actions
bot
added
the
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
label
Mar 5, 2022
bors bot
pushed a commit
that referenced
this pull request
Mar 5, 2022
…ommute, its closure/adjoin is also commutative (#12231) We show that if a set of elements of a subobject commute, its closure/adjoin is also commutative The subobjects include (additive) submonoids, (additive) subgroups, subsemirings, subrings, and subalgebras. Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(ring_theory/adjoin/basic): if a set of elements of a subobject commute, its closure/adjoin is also commutative
[Merged by Bors] - feat(ring_theory/adjoin/basic): if a set of elements of a subobject commute, its closure/adjoin is also commutative
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
delegated
The PR author may merge after reviewing final suggestions.
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We show that if a set of elements of a subobject commute, its closure/adjoin is also commutative The subobjects include (additive) submonoids, (additive) subgroups, subsemirings, subrings, and subalgebras.