Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/sesquilinear_form): preliminary results for nondegeneracy #12269

Closed
wants to merge 22 commits into from

Conversation

mcdoll
Copy link
Member

@mcdoll mcdoll commented Feb 24, 2022

Several lemmas needed to define nondegenerate bilinear forms and show that the canonical pairing of the algebraic dual is nondegenerate.

Add domain restriction of bilinear maps in the second component and in both compenents.

Some type-class generalizations for symmetric, alternating, and reflexive sesquilinear forms.


Open in Gitpod

@mcdoll mcdoll added the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 24, 2022
@mcdoll mcdoll changed the title feat(linear_algebra/sesquilinear_forms): add nondegeneracy feat(linear_algebra/sesquilinear_form): add nondegeneracy Feb 24, 2022
@mcdoll mcdoll added the awaiting-review The author would like community review of the PR label Feb 24, 2022
@mcdoll
Copy link
Member Author

mcdoll commented Feb 24, 2022

I don't see why the build fails, algebra/quandle does not import any file I changed

@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 28, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 4, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 4, 2022
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 6, 2022
@semorrison
Copy link
Collaborator

Just labelling awaiting-author while you fix the warning from the linter. Please mark back as awaiting-review when you're ready!

@mcdoll
Copy link
Member Author

mcdoll commented Mar 6, 2022

Oh, I am sorry. I did not expect the linter to complain.

@mcdoll mcdoll added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 6, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to split all the small changes to prerequisite files into a separate PR. They look ready for merging to me. Then the reviews can focus on the new material.

src/linear_algebra/sesquilinear_form.lean Outdated Show resolved Hide resolved
src/linear_algebra/sesquilinear_form.lean Outdated Show resolved Hide resolved
src/linear_algebra/sesquilinear_form.lean Outdated Show resolved Hide resolved
src/linear_algebra/sesquilinear_form.lean Outdated Show resolved Hide resolved
src/linear_algebra/sesquilinear_form.lean Outdated Show resolved Hide resolved
src/linear_algebra/sesquilinear_form.lean Outdated Show resolved Hide resolved
src/linear_algebra/sesquilinear_form.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 11, 2022
@mcdoll
Copy link
Member Author

mcdoll commented Mar 11, 2022

what is the best way to do the split in git? I would just cut and paste all the nondegenerate stuff into a new PR, but maybe there is a better option

@mcdoll mcdoll added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 14, 2022
@mcdoll mcdoll changed the title feat(linear_algebra/sesquilinear_form): add nondegeneracy feat(linear_algebra/sesquilinear_form): preliminary results for nondegeneracy Mar 14, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Mar 14, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 18, 2022
bors bot pushed a commit that referenced this pull request Mar 18, 2022
…generacy (#12269)

Several lemmas needed to define nondegenerate bilinear forms and show that the canonical pairing of the algebraic dual is nondegenerate.

Add domain restriction of bilinear maps in the second component and in both compenents.

Some type-class generalizations for symmetric, alternating, and reflexive sesquilinear forms.
@bors
Copy link

bors bot commented Mar 18, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/sesquilinear_form): preliminary results for nondegeneracy [Merged by Bors] - feat(linear_algebra/sesquilinear_form): preliminary results for nondegeneracy Mar 18, 2022
@bors bors bot closed this Mar 18, 2022
@bors bors bot deleted the mcdoll/bilinear_refactor branch March 18, 2022 21:54
jjaassoonn pushed a commit that referenced this pull request Mar 21, 2022
…generacy (#12269)

Several lemmas needed to define nondegenerate bilinear forms and show that the canonical pairing of the algebraic dual is nondegenerate.

Add domain restriction of bilinear maps in the second component and in both compenents.

Some type-class generalizations for symmetric, alternating, and reflexive sesquilinear forms.
bors bot pushed a commit that referenced this pull request Feb 21, 2023
… new file. (#18468)

This cuts the import path. The copyright comes from #12269.

I chose not to just move these lemmas to `linear_algebra/basis` as this file is already huge.

The moved lemmas are now stated slightly more generally (`comm_semiring` rather than `comm_ring`), which seems to have been an accident in the original file as no proofs had to change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants