New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(field_theory/cardinality): cardinality of fields & localizations #12285
Conversation
|
||
/-- All finite localizations of integral domains at submonoids not containing zero have the same | ||
cardinality as the base domain. -/ | ||
lemma card {R : Type u} [comm_ring R] {S : submonoid R} {L : Type v} [comm_ring L] [algebra R L] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you generalize localization_map_bijective_of_field
to integral domains and then prove this lemma directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is true, right? the Z -> Q algebra map is clearly not bijective
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant for finite integral domains. So the literal statement you proved, just with a different formulation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see! Yes, I'll do that. I think the real missing glue is a way to automagically turn a finite ID into a field, so I'll add that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or something like is_field_of_is_domain_of_fintype
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, do you think I should split some stuff now with all these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's probably a good idea to open a smaller PR that only talk about fields and integral domains, without cardinality involved.
About cardinality, essentially the same proof shows that this is also the list of a cardinalities of integral domains.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a couple of these leafs. I'll extend the proof to integral domains too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I realised that it's not so obvious to state this for integral domains, as integral domains are bundled. You'd have to have a spec
lemma, and so on...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see... don't bother too much about that
|
thanks so much! I merged your changes, if that's ok :) |
Sure, you're welcome! |
The surjective result can be generalized to Artinian rings, see e.g. https://math.stackexchange.com/questions/1531139/localizations-of-an-artinian-ring-are-isomorphic-to-quotients |
isn't this a tiny bit more specialized, though? because not all ideals are prime? This seems like a fun result to get in regardless, however :) |
Oh yes it only deals with the |
Yes, let's not transform this in a whole API for artinians rings :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
✌️ ericrbg can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Johan Commelin <johan@commelin.net>
bors r+ (below 100 chars) |
…#12285) Co-authored-by: Junyan Xu <junyanxumath@gmail.com> Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
There is indeed a simple proof of the fact that localization of (commutative) artinian rings are surjections: it suffices to show that for all s in the submonoid, 1/s is in the image. The decreasing sequence of ideals (s^n) stabilizes, say (s^n) = (s^(n+1)), then s^n = s^(n+1) r for some r in the original ring, so 1/s is the image of r. I have tried a bit to formalize it and this is as far as I get; I haven't had time to continue it so someone interested may finish and PR it. However I'm not sure if this result is worth being in mathlib; maybe we should construct the product decomposition for artinian rings and could probably show localizations are projections to certain factors.
|
Do we know that that really is 1/s? We can't cancel, right? [sorry to necro this, I decided to use this as an exercise - it's probably worth being in mathlib if it's true as it's a generalisation of something we already have] |
Here's a full proof;
|
oh, of course, we only have to worry about the problem in the localisation itself. many thanks! I'll PR this under your authorship, if that's okay! |
localization_map_bijective
rename &field
instance version #12375