Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/star): replace star_monoid with star_semigroup #12299

Closed
wants to merge 7 commits into from

Conversation

semorrison
Copy link
Collaborator

In preparation for allowing non-unital C^* algebras, replace star_monoid with star_semigroup.


Open in Gitpod

@semorrison semorrison added the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 26, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 26, 2022
@semorrison semorrison added the awaiting-review The author would like community review of the PR label Feb 26, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented Feb 28, 2022

Awesome, thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 28, 2022
@bors
Copy link

bors bot commented Feb 28, 2022

Merge conflict.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Feb 28, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Feb 28, 2022
@semorrison
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Mar 2, 2022
In preparation for allowing non-unital C^* algebras, replace star_monoid with star_semigroup.




Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Mar 2, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/star): replace star_monoid with star_semigroup [Merged by Bors] - feat(algebra/star): replace star_monoid with star_semigroup Mar 2, 2022
@bors bors bot closed this Mar 2, 2022
@bors bors bot deleted the semorrison/star_semigroup branch March 2, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants