[Merged by Bors] - feat(algebra/ring): add non-unital and non-associative rings #12300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
the
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
semorrison
added
the
awaiting-review
|
Unfortunately add a few more steps to the hierarchy makes a few more unification problems fail, so much of this PR is patching up proofs that used to work. Hopefully none of the patches are too unpleasant? |
2 tasks
I'm encouraged by the fact that we seemed to need only 8 patches in a codebase with c.800k lines. Thanks for doing this. (I wonder what will happen when we want to talk about commutative non-unital rings 😨) bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2022
Following up on #11124. The longer term goal is to develop C^* algebras, where non-unital algebras are an essential part of the theory. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2022
Following up on #11124. The longer term goal is to develop C^* algebras, where non-unital algebras are an essential part of the theory. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Build failed: |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2022
Following up on #11124. The longer term goal is to develop C^* algebras, where non-unital algebras are an essential part of the theory. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #11124.
The longer term goal is to develop C^* algebras, where non-unital algebras are an essential part of the theory.