Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(linear_algebra/basic): make linear_map.id_coe elegible for dsimp #12334

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Feb 27, 2022

dsimp only considers lemmas which are proved by rfl, not ones that just could be.


Open in Gitpod

@eric-wieser eric-wieser added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Feb 27, 2022
@eric-wieser eric-wieser changed the title chore(linear_algebra/basic): make linear_map.id_coe elegible for `d… chore(linear_algebra/basic): make linear_map.id_coe elegible for dsimp Feb 27, 2022
@eric-wieser eric-wieser added the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 27, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 27, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented Feb 27, 2022

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 27, 2022
bors bot pushed a commit that referenced this pull request Feb 27, 2022
…simp` (#12334)

`dsimp` only considers lemmas which _are_ proved by `rfl`, not ones that just _could_ be.
@bors
Copy link

bors bot commented Feb 28, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(linear_algebra/basic): make linear_map.id_coe elegible for dsimp [Merged by Bors] - chore(linear_algebra/basic): make linear_map.id_coe elegible for dsimp Feb 28, 2022
@bors bors bot closed this Feb 28, 2022
@bors bors bot deleted the eric-wieser/id_coe-dsimp branch February 28, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants