Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/full_subcategory): full_subcategory.map and full_subcategory.lift #12335

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(category_theory/full_subcategory): full_subcategory.map and full_subcategory.lift #12335

wants to merge 3 commits into from

Conversation

TwoFX
Copy link
Member

@TwoFX TwoFX commented Feb 27, 2022

Open in Gitpod

@TwoFX TwoFX added the awaiting-review The author would like community review of the PR label Feb 27, 2022
@TwoFX TwoFX mentioned this pull request Feb 27, 2022
Closed
1 task
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 1, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 1, 2022
jcommelin
jcommelin approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

src/category_theory/full_subcategory.lean Outdated
original functor. Unfortunately, this is not true by definition, so we only get a natural
isomorphism, but it is pointwise definitionally true, see
`full_subcategory.inclusion_obj_lift_obj` and `full_subcategory.inclusion_map_lift_map`. -/
def full_subcategory.lift_factor (F : C ⥤ D) (hF : ∀ X, P (F.obj X)) :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be called lift_comp_inclusion?

@bors
Copy link

bors bot commented Mar 3, 2022

✌️ TwoFX can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Mar 3, 2022
@TwoFX
Copy link
Member Author

TwoFX commented Mar 5, 2022

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Mar 5, 2022
bors bot pushed a commit that referenced this pull request Mar 5, 2022
@TwoFX
feat(category_theory/full_subcategory): full_subcategory.map and full…
e542154 
…_subcategory.lift (#12335)
@bors
Copy link

bors bot commented Mar 5, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/full_subcategory): full_subcategory.map and full_subcategory.lift [Merged by Bors] - feat(category_theory/full_subcategory): full_subcategory.map and full_subcategory.lift Mar 5, 2022
@bors bors bot closed this Mar 5, 2022
@bors bors bot deleted the full_subcategory_map branch March 5, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TwoFX @jcommelin @leanprover-community-bot-assistant