[Merged by Bors] - chore(algebra/big_operators): generalize map_prod to monoid_hom_class
#12354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vierkantor
added
awaiting-review
2 tasks
github-actions
bot
removed
the
awaiting-CI
eric-wieser
reviewed
Mar 1, 2022
eric-wieser
reviewed
Mar 1, 2022
eric-wieser
approved these changes
Mar 1, 2022
|
✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Vierkantor
commented
Mar 1, 2022
Vierkantor
commented
Mar 1, 2022
Vierkantor
commented
Mar 1, 2022
Vierkantor
commented
Mar 1, 2022
Vierkantor
commented
Mar 1, 2022
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2022
…ass` (#12354) This PR generalizes the following lemmas to `(add_)monoid_hom_class`: * `map_prod`, `map_sum` * `map_multiset_prod`, `map_multiset_sum` * `map_list_prod`, `map_list_sum` * `map_finsupp_prod`, `map_finsupp_sum` I haven't removed any of the existing specialized, namespaced versions of these lemmas yet, but I have marked them as `protected` and added a docstring saying to use the generic version instead. Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
github-actions
bot
added
the
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
map_prod to monoid_hom_classmap_prod to monoid_hom_class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes the following lemmas to
(add_)monoid_hom_class:map_prod,map_summap_multiset_prod,map_multiset_summap_list_prod,map_list_summap_finsupp_prod,map_finsupp_sumI haven't removed any of the existing specialized, namespaced versions of these lemmas yet, but I have marked them as
protectedand added a docstring saying to use the generic version instead.