Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(data/polynomial/monic): remove useless lemma #12364

Closed
wants to merge 1 commit into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Mar 1, 2022

There is a nontrivial version of this lemma (ne_zero_of_monic) which actually has uses in the library, unlike this deleted lemma. We also tidy the proof of the lemma below.


Open in Gitpod

@ericrbg ericrbg added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Mar 1, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented Mar 1, 2022

Thanks

bors d+

@bors
Copy link

bors bot commented Mar 1, 2022

✌️ ericrbg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Mar 1, 2022
@ericrbg
Copy link
Collaborator Author

ericrbg commented Mar 1, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 1, 2022
There is a `nontrivial` version of this lemma (`ne_zero_of_monic`) which actually has uses in the library, unlike this deleted lemma. We also tidy the proof of the lemma below.
@bors
Copy link

bors bot commented Mar 1, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Mar 1, 2022
There is a `nontrivial` version of this lemma (`ne_zero_of_monic`) which actually has uses in the library, unlike this deleted lemma. We also tidy the proof of the lemma below.
@bors
Copy link

bors bot commented Mar 1, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/polynomial/monic): remove useless lemma [Merged by Bors] - chore(data/polynomial/monic): remove useless lemma Mar 1, 2022
@bors bors bot closed this Mar 1, 2022
@bors bors bot deleted the ericrbg/monic_lemma branch March 1, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants