Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/clifford_algebra/conjugation): reverse and involute are grade-preserving #12373

Closed
wants to merge 5 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Mar 1, 2022

This shows that various submodules are preserved under submodule.map by reverse or involute.


Open in Gitpod

The related results x ∈ even_odd Q 0 ↔ involute x = x and x ∈ even_odd Q 1 ↔ involute x = -x will come in a future PR.

@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Mar 1, 2022
@eric-wieser
Copy link
Member Author

eric-wieser commented Mar 1, 2022

I tried to state this in terms of submodule.map instead, but found it to be rather annoying:

lemma _root_.submodule.map_eq_self_of_involutive_of_le {p : submodule R M}
  {f : M →ₗ[R] M} (hf : function.involutive f) (h : p.map f ≤ p) : p.map f = p :=
have f_comp_f : f.comp f = linear_map.id := linear_map.ext hf,
have heq : p = (p.map f).map f, by rw [←submodule.map_comp, f_comp_f, submodule.map_id],
le_antisymm h $ heq.trans_le $ (submodule.map_strict_mono_of_injective hf.injective).monotone h

lemma ι_range_map_reverse : (ι Q).range.map reverse = (ι Q).range :=
submodule.map_eq_self_of_involutive_of_le reverse_involutive $ begin
  rintros _ ⟨_, ⟨m, rfl⟩, rfl⟩,
  rw reverse_ι,
  exact linear_map.mem_range_self _ _
end

lemma submodule_mul_map_reverse (p q : submodule R $ clifford_algebra Q) :
  (p * q).map reverse = q.map reverse * p.map reverse := sorry

lemma submodule_pow_map_reverse (p : submodule R $ clifford_algebra Q) (n : ℕ):
  (p ^ n).map reverse = p.map reverse ^ n := sorry

The lemmas in #12374 would probably help, but I don't know they'd make the proofs all that much shorter anyway.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Mar 3, 2022
@leanprover-community-bot-assistant
Copy link
Collaborator

1 similar comment
@leanprover-community-bot-assistant
Copy link
Collaborator

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 3, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 3, 2022
@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 3, 2022
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 4, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 5, 2022
bors bot pushed a commit that referenced this pull request Mar 5, 2022
…te are grade-preserving (#12373)

This shows that various submodules are preserved under `submodule.map` by `reverse` or `involute`.
@bors
Copy link

bors bot commented Mar 5, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/clifford_algebra/conjugation): reverse and involute are grade-preserving [Merged by Bors] - feat(linear_algebra/clifford_algebra/conjugation): reverse and involute are grade-preserving Mar 5, 2022
@bors bors bot closed this Mar 5, 2022
@bors bors bot deleted the eric-wieser/clifford-even-reverse branch March 5, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants