Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linear_algebra/finite_dimensional): finite dimensional vector spaces #1241
feat(linear_algebra/finite_dimensional): finite dimensional vector spaces #1241
Changes from 8 commits
e23c522
3ca6232
abb3dfe
78c79e7
c51eba9
7d338dc
b877854
204635f
ad92307
fad0e34
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be a bit awkward at first, but shouldn't we just use
is_noetherian
? (Just like we shouldn't havevector_space
in the first place.@digama0 What do you think? Should this be a reducible def? Or an abbreviation? Or should it not be there at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is slightly different than how it's done with vector spaces. It's a reducible der, so you shouldn't have to define an instance when there's already an
is_noetherian
instance floating around.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do use
is_noetherian
there definitely should be clear documentation of this somewhere, so people know where to look for finite dimensional vector spaces