[Merged by Bors] - feat(analysis/complex/upper_half_plane): extend action on upper half plane to GL_pos #12415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
May 27, 2022
eric-wieser
reviewed
May 27, 2022
eric-wieser
reviewed
May 27, 2022
eric-wieser
reviewed
May 27, 2022
eric-wieser
reviewed
May 27, 2022
eric-wieser
reviewed
May 27, 2022
| /-- The action of `SL(2, ℝ)` on the upper half-plane by fractional linear transformations. -/ | ||
| instance : mul_action SL(2, ℝ) ℍ := | ||
| /-- The action of ` GL_pos 2 ℝ` on the upper half-plane by fractional linear transformations. -/ | ||
| instance : mul_action (GL(2, ℝ)⁺) ℍ := |
There was a problem hiding this comment.
Does this work without the ()?
Suggested change
| instance : mul_action (GL(2, ℝ)⁺) ℍ := | |
| instance : mul_action GL(2, ℝ)⁺ ℍ := |
There was a problem hiding this comment.
no, it complains :(
eric-wieser
reviewed
May 27, 2022
eric-wieser
reviewed
May 27, 2022
|
LGTM. Can you please update the description? If it is really a draft we should wait to merge it... |
No its no longer a draft, the description was outdated. |
|
Thanks! bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jun 3, 2022
…plane to GL_pos (#12415) This extends the action on the upper half plane from `SL_2` to `GL_pos`, Co-authored-by: AlexKontorovich <58564076+AlexKontorovich@users.noreply.github.com>
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
tomaz1502
pushed a commit
that referenced
this pull request
Jun 3, 2022
…plane to GL_pos (#12415) This extends the action on the upper half plane from `SL_2` to `GL_pos`, Co-authored-by: AlexKontorovich <58564076+AlexKontorovich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the action on the upper half plane from
SL_2toGL_pos,