[Merged by Bors] - feat(combinatorics/simple_graph/density): Edge density #12431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
YaelDillies
changed the title
|
Looks reasonable to me, and I didn't notice anything that's in need of improvement. One slight inaccuracy is that, technically, interedges are darts -- if the expectation is that the main use case is that the two vertex sets are disjoint, I think this is OK. You might consider making things be dart-valued, but I suggest only doing that if in the short term that would be useful. (Justification: if this ever changes in the future, it should be an easy refactor.) @awainverse Would you mind taking a look at the relations part of this PR? Would you have a home for it that you'd prefer over |
awainverse
reviewed
Mar 22, 2022
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 24, 2022
Define the number and density of edges of a relation and of a simple graph between two finsets. Co-authored-by: Bhavik Mehta <bhavik.mehta8@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define the number and density of edges of a relation and of a simple graph between two finsets.
Co-authored-by: Bhavik Mehta bhavik.mehta8@gmail.com
From SRL