Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(analysis/complex/basic): golf norm_rat/int/int_of_nonneg #12433

Closed
wants to merge 1 commit into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Mar 3, 2022

While looking at PR #12428, I found some easy golfing of some lemmas (featuring my first-ever use of single_pass! 馃槃 ).


Open in Gitpod

Copy link
Collaborator

@ericrbg ericrbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@adomani adomani added the awaiting-review The author would like community review of the PR label Mar 3, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 馃帀

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 4, 2022
bors bot pushed a commit that referenced this pull request Mar 4, 2022
)

While looking at PR #12428, I found some easy golfing of some lemmas (featuring my first-ever use of `single_pass`! 馃槃 ).
@bors
Copy link

bors bot commented Mar 4, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Mar 4, 2022
)

While looking at PR #12428, I found some easy golfing of some lemmas (featuring my first-ever use of `single_pass`! 馃槃 ).
@bors
Copy link

bors bot commented Mar 4, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(analysis/complex/basic): golf norm_rat/int/int_of_nonneg [Merged by Bors] - chore(analysis/complex/basic): golf norm_rat/int/int_of_nonneg Mar 4, 2022
@bors bors bot closed this Mar 4, 2022
@bors bors bot deleted the adomani_norm_golf branch March 4, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants