Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(field_theory/cardinality): a cardinal can have a field structure iff it is a prime power #12442

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(field_theory/cardinality): a cardinal can have a field structure iff it is a prime power #12442

wants to merge 4 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Mar 4, 2022

Open in Gitpod

@ericrbg ericrbg added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Mar 4, 2022
jcommelin
jcommelin approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

src/field_theory/cardinality.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Mar 4, 2022

✌️ ericrbg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Mar 4, 2022
@ericrbg @jcommelin
iff
1577dda 
Co-authored-by: Johan Commelin <johan@commelin.net>
@ericrbg @Vierkantor
less clunky proof
c997d65 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@ericrbg
Copy link
Collaborator Author

ericrbg commented Mar 4, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 4, 2022
@ericrbg
feat(field_theory/cardinality): a cardinal can have a field structure…
30d63cd 
… iff it is a prime power (#12442)

Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
@bors
Copy link

bors bot commented Mar 4, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(field_theory/cardinality): a cardinal can have a field structure iff it is a prime power [Merged by Bors] - feat(field_theory/cardinality): a cardinal can have a field structure iff it is a prime power Mar 4, 2022
@bors bors bot closed this Mar 4, 2022
@bors bors bot deleted the ericrbg/cute_result branch March 4, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor left review comments

@vihdzp vihdzp vihdzp left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ericrbg @Vierkantor @jcommelin @vihdzp @leanprover-community-bot-assistant