New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(order/category/BoolAlg): The category of Boolean algebras #12452
Conversation
@@ -754,6 +754,14 @@ end of_core | |||
section boolean_algebra | |||
variables [boolean_algebra α] | |||
|
|||
--TODO@Yaël: Once we have co-Heyting algebras, we won't need to go through `boolean_algebra.of_core` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not leave names attached to TODOs, unless you have a very concrete immediate plan to do it in a follow-up PR. Otherwise it's just cleanup work and confusion later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have such a plan :)
bors d+ |
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
Define `BoolAlg`, the category of Boolean algebras with bounded lattice homs.
Pull request successfully merged into master. Build succeeded: |
Define
BoolAlg
, the category of Boolean algebras with bounded lattice homs.