Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(set_theory/*): o.out.r → < #12468

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - refactor(set_theory/*): o.out.r → < #12468

wants to merge 9 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Mar 6, 2022

We declare a linear_order instance on o.out.α, for o : ordinal, with < def-eq to o.out.r. This will improve code clarity and will allow us to state theorems about specific ordinals as ordered structures.

Open in Gitpod

@vihdzp vihdzp added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Mar 6, 2022
@vihdzp vihdzp requested a review from sgouezel March 6, 2022 02:25
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Mar 6, 2022
@vihdzp vihdzp mentioned this pull request Mar 6, 2022
Closed
1 task
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 6, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 6, 2022
jcommelin
jcommelin approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 7, 2022
bors bot pushed a commit that referenced this pull request Mar 7, 2022
@vihdzp
refactor(set_theory/*): o.out.r → < (#12468)
d704f27 
We declare a `linear_order` instance on `o.out.α`, for `o : ordinal`, with `<` def-eq to `o.out.r`. This will improve code clarity and will allow us to state theorems about specific ordinals as ordered structures.
@bors
Copy link

bors bot commented Mar 7, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(set_theory/*): o.out.r → < [Merged by Bors] - refactor(set_theory/*): o.out.r → < Mar 7, 2022
@bors bors bot closed this Mar 7, 2022
@bors bors bot deleted the ordinal_out_le branch March 7, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison approved these changes

@jcommelin jcommelin jcommelin approved these changes

@sgouezel sgouezel Awaiting requested review from sgouezel

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vihdzp @semorrison @jcommelin @leanprover-community-bot-assistant