Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/finset/noncomm_prod): add noncomm_prod_commute #12521

Closed
wants to merge 2 commits into from

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Mar 8, 2022

adding list.prod_commute, multiset.noncomm_prod_commute and
finset.noncomm_prod_commute.


Instead of a complicated induction over finsets, I now just prove the lemma for the underlying structures, which is more useful anyways

Open in Gitpod

adding `list.prod_commute`, `multiset.noncomm_prod_commute` and
`finset.noncomm_prod_commute`.
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@nomeata nomeata requested a review from eric-wieser March 8, 2022 13:53
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 8, 2022
bors bot pushed a commit that referenced this pull request Mar 8, 2022
adding `list.prod_commute`, `multiset.noncomm_prod_commute` and
`finset.noncomm_prod_commute`.
@bors
Copy link

bors bot commented Mar 8, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/finset/noncomm_prod): add noncomm_prod_commute [Merged by Bors] - feat(data/finset/noncomm_prod): add noncomm_prod_commute Mar 8, 2022
@bors bors bot closed this Mar 8, 2022
@bors bors bot deleted the joachim/noncomm_prod_commute branch March 8, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants