Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(algebra/group/to_additive): monadic code cosmetics #12527

Closed
wants to merge 6 commits into from

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Mar 8, 2022

as suggested by @kmill and @eric-wieser, but the merge was faster

Also improve test file.


Open in Gitpod

@nomeata nomeata added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Mar 8, 2022
@nomeata nomeata changed the title chore(algebra/group/to_additive): monadic code cosmetics refactor(algebra/group/to_additive): monadic code cosmetics Mar 8, 2022
@nomeata nomeata removed the easy < 20s of review time. See the lifecycle page for guidelines. label Mar 8, 2022
@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 11, 2022
bors bot pushed a commit that referenced this pull request Mar 11, 2022
as suggested by @kmill and @eric-wieser, but the merge was faster

Also improve test file.
@bors
Copy link

bors bot commented Mar 11, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(algebra/group/to_additive): monadic code cosmetics [Merged by Bors] - refactor(algebra/group/to_additive): monadic code cosmetics Mar 11, 2022
@bors bors bot closed this Mar 11, 2022
@bors bors bot deleted the joachim/to_additive_doc_lint_fixes branch March 11, 2022 10:13
laurentbartholdi pushed a commit that referenced this pull request Mar 17, 2022
as suggested by @kmill and @eric-wieser, but the merge was faster

Also improve test file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants