Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(analysis/locally_convex): add balanced hull and core #12537

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - feat(analysis/locally_convex): add balanced hull and core #12537

wants to merge 10 commits into from

Conversation

mcdoll
Copy link
Member

@mcdoll mcdoll commented Mar 8, 2022 •
edited by github-actions bot
Loading

@mcdoll mcdoll added the RFC Request for comment label Mar 8, 2022
@mcdoll mcdoll changed the title feat(analysis/seminorm): add balanced hull and core feat(analysis/locally_convex): add balanced hull and core Mar 12, 2022
@mcdoll mcdoll mentioned this pull request Mar 13, 2022
Closed
@leanprover-community-bot-assistant leanprover-community-bot-assistant added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Mar 13, 2022
@leanprover-community-bot-assistant
Copy link
Collaborator

This PR/issue depends on:

@mcdoll mcdoll added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. and removed RFC Request for comment labels Mar 14, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Mar 14, 2022
@mcdoll mcdoll marked this pull request as ready for review March 15, 2022 09:57
@mcdoll mcdoll mentioned this pull request Mar 17, 2022
Closed
2 tasks
dupuisf
dupuisf reviewed Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just left a few comment about naming.

bors d+

src/analysis/locally_convex/balanced_core_hull.lean Outdated Show resolved Hide resolved
src/analysis/locally_convex/balanced_core_hull.lean Outdated Show resolved Hide resolved
src/analysis/locally_convex/balanced_core_hull.lean Outdated Show resolved Hide resolved
src/analysis/locally_convex/balanced_core_hull.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Mar 29, 2022

✌️ mcdoll can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Mar 29, 2022
@mcdoll
Copy link
Member Author

mcdoll commented Mar 29, 2022

bors merge

thanks for reviewing

bors bot pushed a commit that referenced this pull request Mar 29, 2022
@mcdoll
feat(analysis/locally_convex): add balanced hull and core (#12537)
1ffd04c
@bors
Copy link

bors bot commented Mar 29, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/locally_convex): add balanced hull and core [Merged by Bors] - feat(analysis/locally_convex): add balanced hull and core Mar 29, 2022
@bors bors bot closed this Mar 29, 2022
@bors bors bot deleted the mcdoll/balanced branch March 29, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcdoll @leanprover-community-bot-assistant @dupuisf