Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(group_theory/solvable): Golf proof #12552

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - refactor(group_theory/solvable): Golf proof #12552

wants to merge 2 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Mar 9, 2022

This PR golfs the proof of insolvability of S_5, using the new commutator notation.

Open in Gitpod

@tb65536 tb65536 added the awaiting-review The author would like community review of the PR label Mar 9, 2022
jcommelin
jcommelin approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed awaiting-review The author would like community review of the PR labels Mar 10, 2022
@bors
Copy link

bors bot commented Mar 10, 2022

Merge conflict.

@tb65536 tb65536 added the awaiting-review The author would like community review of the PR label Mar 10, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 10, 2022
@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot removed the awaiting-review The author would like community review of the PR label Mar 11, 2022
bors bot pushed a commit that referenced this pull request Mar 11, 2022
@tb65536
refactor(group_theory/solvable): Golf proof (#12552)
1a581ed 
This PR golfs the proof of insolvability of S_5, using the new commutator notation.
@bors
Copy link

bors bot commented Mar 11, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(group_theory/solvable): Golf proof [Merged by Bors] - refactor(group_theory/solvable): Golf proof Mar 11, 2022
@bors bors bot closed this Mar 11, 2022
@bors bors bot deleted the commutator2 branch March 11, 2022 10:13
laurentbartholdi pushed a commit that referenced this pull request Mar 17, 2022
@tb65536 @laurentbartholdi
refactor(group_theory/solvable): Golf proof (#12552)
36b4d5c 
This PR golfs the proof of insolvability of S_5, using the new commutator notation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tb65536 @semorrison @jcommelin @leanprover-community-bot-assistant