Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(set_theory/ordinal_arithmetic): Make auxiliary result private #12562

Closed
wants to merge 1 commit into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Mar 10, 2022


Open in Gitpod

@vihdzp vihdzp added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Mar 10, 2022
@jcommelin
Copy link
Member

Mathlib generally follows the philosophy of making very few things private. Because it happens that such aux lemmas are often useful in ways that the author didn't expect. And making them private makes them harder to discover.

@vihdzp
Copy link
Collaborator Author

vihdzp commented Mar 10, 2022

Mathlib generally follows the philosophy of making very few things private. Because it happens that such aux lemmas are often useful in ways that the author didn't expect. And making them private makes them harder to discover.

This auxiliary result is made entirely redundant by CNF_pairwise and CNF_fst_le_log. As far as I can see, the only reason it exists is to factor out commonalities in the proofs.

@jcommelin
Copy link
Member

Ok, fair enough.

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 10, 2022
@bors
Copy link

bors bot commented Mar 10, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(set_theory/ordinal_arithmetic): Make auxiliary result private [Merged by Bors] - chore(set_theory/ordinal_arithmetic): Make auxiliary result private Mar 10, 2022
@bors bors bot closed this Mar 10, 2022
@bors bors bot deleted the CNF_aux branch March 10, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants