[Merged by Bors] - refactor(linear_algebra/ray): redefine same_ray to allow zero vectors
#12618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Mar 12, 2022
urkud
commented
Mar 12, 2022
3 tasks
hrmacbeth
reviewed
Mar 13, 2022
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
|
@eric-wieser Could you please have another look? |
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 17, 2022
…rs (#12618) In a strictly convex space, the new definition is equivalent to the fact that the triangle inequality becomes an equality. The old definition was only used for nonzero vectors in `mathlib`. Also make the definition of `ray_vector` semireducible so that `ray_vector.setoid` can be an instance.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
same_ray to allow zero vectorssame_ray to allow zero vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a strictly convex space, the new definition is equivalent to the fact that the triangle inequality becomes an equality. The old definition was only used for nonzero vectors in
mathlib. Also make the definition ofray_vectorsemireducible so thatray_vector.setoidcan be an instance.