Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/algebra/basic,data/matrix/basic): resolve a TODO about alg_hom.map_smul_of_tower #12684

Closed
wants to merge 5 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Mar 14, 2022

It turns out that this lemma doesn't actually help in the place I claimed it would, so I added the lemma that does help too.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Mar 14, 2022
@eric-wieser eric-wieser changed the title feat(algebra/algebra/basic): add alg_hom.map_smul_of_tower feat(algebra/algebra/basic,data/matrix/basic): resolve a TODO about alg_hom.map_smul_of_tower Mar 14, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Mar 16, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 16, 2022
bors bot pushed a commit that referenced this pull request Mar 16, 2022
…alg_hom.map_smul_of_tower` (#12684)

It turns out that this lemma doesn't actually help in the place I claimed it would, so I added the lemma that does help too.
@bors
Copy link

bors bot commented Mar 16, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Mar 16, 2022
…alg_hom.map_smul_of_tower` (#12684)

It turns out that this lemma doesn't actually help in the place I claimed it would, so I added the lemma that does help too.
@bors
Copy link

bors bot commented Mar 16, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/algebra/basic,data/matrix/basic): resolve a TODO about alg_hom.map_smul_of_tower [Merged by Bors] - feat(algebra/algebra/basic,data/matrix/basic): resolve a TODO about alg_hom.map_smul_of_tower Mar 16, 2022
@bors bors bot closed this Mar 16, 2022
@bors bors bot deleted the eric-wieser/alg_hom.map_smul_of_tower branch March 16, 2022 21:17
laurentbartholdi pushed a commit that referenced this pull request Mar 17, 2022
…alg_hom.map_smul_of_tower` (#12684)

It turns out that this lemma doesn't actually help in the place I claimed it would, so I added the lemma that does help too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants