fix(algebraic_geometry/presheafedspace): fix lame proofs #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
reviewed
Jul 28, 2019
|
Looks good to me, modulo 1 typo. |
Co-Authored-By: Johan Commelin <johan@commelin.net>
jcommelin
approved these changes
Jul 28, 2019
jcommelin
added
the
ready-to-merge
| @@ -3,12 +3,23 @@ | |||
| -- Authors: Scott Morrison | |||
There was a problem hiding this comment.
I think we use /- -/ comment in this header
|
I'm pretty sure my docs PR #1264 fixes this one.
…On Sun, Jul 28, 2019 at 9:00 PM Patrick Massot ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/algebraic_geometry/presheafed_space.lean
<#1273 (comment)>
:
> @@ -3,12 +3,23 @@
-- Authors: Scott Morrison
I think we use /- -/ comment in this header
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1273?email_source=notifications&email_token=AADUWBGII4FLBMCZE6J3BSDQBV34JA5CNFSM4IHLOEA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7Y3ZWI#pullrequestreview-267500761>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADUWBA5RCU74TGZUTK4EKTQBV34JANCNFSM4IHLOEAQ>
.
|
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…community#1273) * fix(algebraic_geometry/presheafedspace): fix lame proofs * fix * Update src/algebraic_geometry/presheafed_space.lean Co-Authored-By: Johan Commelin <johan@commelin.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the proofs that @robertylewis copied and tweaked from
tidy, after discovering thattidywas running too slowly in this file.I'm still sad about having to include these proofs at all, and dream about having a proper caching mechanism so we can write automation.
I also improved documentation by epsilon.