Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - docs(order/filter/basic): fix docstring of generate #12734

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - docs(order/filter/basic): fix docstring of generate #12734

wants to merge 1 commit into from

Conversation

jcommelin
Copy link
Member

Open in Gitpod

@jcommelin jcommelin added awaiting-review The author would like community review of the PR docs This PR is about documentation easy < 20s of review time. See the lifecycle page for guidelines. labels Mar 16, 2022
ADedecker
ADedecker approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 21, 2022
bors bot pushed a commit that referenced this pull request Mar 21, 2022
@jcommelin
docs(order/filter/basic): fix docstring of generate (#12734)
df299a1
@bors
Copy link

bors bot commented Mar 21, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title docs(order/filter/basic): fix docstring of generate [Merged by Bors] - docs(order/filter/basic): fix docstring of generate Mar 21, 2022
@bors bors bot closed this Mar 21, 2022
@bors bors bot deleted the filter-generate-docstring branch March 21, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADedecker ADedecker ADedecker approved these changes

Assignees
No one assigned
Labels
docs This PR is about documentation easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcommelin @riccardobrasca @ADedecker