Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebraic_geometry/projective_spectrum): Proj as a locally ringed space #12773

Closed
wants to merge 70 commits into from
Closed

[Merged by Bors] - feat(algebraic_geometry/projective_spectrum): Proj as a locally ringed space #12773

wants to merge 70 commits into from

Conversation

jjaassoonn
Copy link
Collaborator

@jjaassoonn jjaassoonn commented Mar 17, 2022 •
edited by github-actions bot

jjaassoonn and others added 30 commits March 13, 2022 01:30
@jjaassoonn
initial
937e721
@jjaassoonn
update docstring
d8e0b45
@jjaassoonn
initial commit
00afcf0
@jjaassoonn
missed a docstring
5e7529d
@jjaassoonn
minigolf
23fa559
@jjaassoonn
implicit variable
0614b75
@jjaassoonn
Update topology.lean
f775112
@jjaassoonn @jcommelin
Apply suggestions from code review
d8cfa3d 
Co-authored-by: Johan Commelin <johan@commelin.net>
@jjaassoonn
update docs
6421947
@jjaassoonn
Update topology.lean
2f92188
@jjaassoonn
add missing instances
4c40b38
@jjaassoonn
Merge branch 'jjaassoonn/proj/Top_basic_defs' of https://github.com/l…
6b74cc1 
…eanprover-community/mathlib into jjaassoonn/proj/Top_basic_defs
@jjaassoonn
initial commit
257d6dc
@jjaassoonn
remove has_mem instance following @eric-wieser's adivce
227eee9
@jjaassoonn @eric-wieser
Update src/ring_theory/graded_algebra/homogeneous_ideal.lean
a46bbae 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@jjaassoonn
delete partial_order
a741e03
@jjaassoonn
update docs
c85f72d
@jjaassoonn
golf + add instance
86b1bf5
@jjaassoonn
refactor
161a7e4
@jjaassoonn @eric-wieser
Update src/ring_theory/graded_algebra/homogeneous_ideal.lean
c3fc5f5 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@jjaassoonn
refactor
b382b24
@jjaassoonn
minigolf
c009a27
@jjaassoonn
refactor
cd5a866
@jjaassoonn
update docs
7643ca5
@jjaassoonn
Merge branch 'jjaassoonn/homogeneous_ideal_set_like' into jjaassoonn/…
b0b6f7f 
…proj/Top_basic_defs
@jjaassoonn
fix
74140d0
@jjaassoonn
fix
25bf0ac
@jjaassoonn
Merge branch 'jjaassoonn/proj/Top_basic_defs' into jjaassoonn/proj/Top
3d61441
@jjaassoonn
fix
ae8ac5f
@jjaassoonn
fix
0e31d10
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 17, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Mar 17, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Mar 30, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Mar 30, 2022
@jjaassoonn jjaassoonn changed the title feat(algebraic_geometry/projective_spectrum): structure sheaf of Proj feat(algebraic_geometry/projective_spectrum): Proj as a locally ringed space Mar 30, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 12, 2022
@leanprover-community-bot-assistant
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 12, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 12, 2022
@jjaassoonn jjaassoonn added the awaiting-review The author would like community review of the PR label Apr 12, 2022
jcommelin
jcommelin approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 12, 2022
bors bot pushed a commit that referenced this pull request Apr 12, 2022
@jjaassoonn
feat(algebraic_geometry/projective_spectrum): Proj as a locally ringe…
6bc2bd6 
…d space (#12773)

This pr is about proving that Proj with its structure sheaf is a locally ringed space
@bors
Copy link

bors bot commented Apr 12, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebraic_geometry/projective_spectrum): Proj as a locally ringed space [Merged by Bors] - feat(algebraic_geometry/projective_spectrum): Proj as a locally ringed space Apr 12, 2022
@bors bors bot closed this Apr 12, 2022
@bors bors bot deleted the jjaassoonn/proj/structure_sheaf branch April 12, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjaassoonn @leanprover-community-bot-assistant @jcommelin