Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/fin/succ_pred): fin is an archimedean succ/pred order #12792

Closed
wants to merge 24 commits into from
Closed

[Merged by Bors] - feat(data/fin/succ_pred): fin is an archimedean succ/pred order #12792

wants to merge 24 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Mar 18, 2022

Open in Gitpod

@ericrbg ericrbg added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR labels Mar 18, 2022
YaelDillies
YaelDillies reviewed Mar 18, 2022
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're clearly missing a constructor for succ_order to make this seamless. Thinking about it...

src/order/succ_pred/basic.lean Outdated Show resolved Hide resolved
src/order/succ_pred/basic.lean Outdated Show resolved Hide resolved
src/order/succ_pred/basic.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Mar 18, 2022
YaelDillies
YaelDillies reviewed Mar 19, 2022
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth waiting for #12597

src/order/succ_pred/basic.lean Outdated Show resolved Hide resolved
src/order/succ_pred/basic.lean Outdated Show resolved Hide resolved
src/order/succ_pred/basic.lean Outdated Show resolved Hide resolved
ericrbg and others added 3 commits March 19, 2022 01:51
@ericrbg @YaelDillies
let's see how the naming goes
a3df66f 
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@ericrbg
move stuff
b4f4d12
@ericrbg
moved
082ffae
@bryangingechen bryangingechen changed the title feat(succ_pred/basic): add fin instances feat(order/succ_pred/basic): add fin instances Mar 19, 2022
@bors
Copy link

bors bot commented Mar 28, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Vierkantor
Vierkantor approved these changes Mar 28, 2022
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, does Yaël have any final remarks?

bors d=@YaelDillies

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Mar 28, 2022
@YaelDillies
Copy link
Collaborator

Could you move the fin instance to a new file data.fin.succ_pred to match data.nat.succ_pred and data.int.succ_pred?

Let's also wait for #12597 because it might give us golfing ideas.

YaelDillies
YaelDillies reviewed Apr 5, 2022
View reviewed changes
src/data/fintype/basic.lean Outdated Show resolved Hide resolved
src/data/fintype/basic.lean Outdated Show resolved Hide resolved
src/order/succ_pred/basic.lean Outdated Show resolved Hide resolved
@YaelDillies YaelDillies changed the title feat(order/succ_pred/basic): add fin instances feat(data/fin/succ_pred): fin is an archimedean succ/pred order Apr 12, 2022
YaelDillies
YaelDillies reviewed Apr 12, 2022
View reviewed changes
src/data/fin/succ_pred.lean Outdated Show resolved Hide resolved
src/data/fin/succ_pred.lean Outdated Show resolved Hide resolved
@ericrbg @YaelDillies
Update src/set_theory/ordinal.lean
42c962c 
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 17, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Apr 17, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 21, 2022
@ericrbg ericrbg added awaiting-review The author would like community review of the PR merge-conflict Please `git merge origin/master` then a bot will remove this label. awaiting-CI The author would like to see what CI has to say before doing more work. labels Apr 21, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 21, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 21, 2022
YaelDillies
YaelDillies reviewed Apr 24, 2022
View reviewed changes
src/data/fin/basic.lean Outdated Show resolved Hide resolved
src/data/fin/succ_pred.lean Outdated Show resolved Hide resolved
src/order/succ_pred/basic.lean Show resolved Hide resolved
src/order/succ_pred/basic.lean Outdated Show resolved Hide resolved
src/data/fin/succ_pred.lean Show resolved Hide resolved
@ericrbg ericrbg mentioned this pull request Apr 24, 2022
Closed
YaelDillies
YaelDillies reviewed Apr 25, 2022
View reviewed changes
src/order/rel_classes.lean Outdated Show resolved Hide resolved
src/order/succ_pred/basic.lean Outdated Show resolved Hide resolved
src/order/succ_pred/basic.lean Outdated Show resolved Hide resolved
src/data/fin/basic.lean Outdated Show resolved Hide resolved
src/data/fin/basic.lean Outdated Show resolved Hide resolved
@YaelDillies
Copy link
Collaborator

Thanks!

bors merge

bors bot pushed a commit that referenced this pull request Apr 25, 2022
@ericrbg @YaelDillies
feat(data/fin/succ_pred): fin is an archimedean succ/pred order (#1…
43e84cd 
…2792)

Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@bors
Copy link

bors bot commented Apr 25, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/fin/succ_pred): fin is an archimedean succ/pred order [Merged by Bors] - feat(data/fin/succ_pred): fin is an archimedean succ/pred order Apr 25, 2022
@bors bors bot closed this Apr 25, 2022
@bors bors bot deleted the ericrbg/fin_succ_archimidean branch April 25, 2022 19:25
@YaelDillies YaelDillies removed the awaiting-review The author would like community review of the PR label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ericrbg @YaelDillies @Vierkantor @leanprover-community-bot-assistant