Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(logic/basic): ulift.down is injective #12824

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(logic/basic): ulift.down is injective #12824

wants to merge 5 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Mar 19, 2022

We also make the arguments to plift.down_inj inferred.

Open in Gitpod

@vihdzp vihdzp added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-CI The author would like to see what CI has to say before doing more work. labels Mar 19, 2022
eric-wieser
eric-wieser reviewed Mar 19, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, can you restate these in terms of function.injective? Or is that not yet available.

The naming guide says the inj lemmas should be iffs

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 19, 2022
@vihdzp vihdzp added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 19, 2022
@jcommelin
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Mar 21, 2022

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Mar 21, 2022
@vihdzp
Copy link
Collaborator Author

vihdzp commented Mar 21, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 21, 2022
@vihdzp
feat(logic/basic): ulift.down is injective (#12824)
c030df6 
We also make the arguments to `plift.down_inj` inferred.
eric-wieser
eric-wieser reviewed Mar 21, 2022
View reviewed changes
src/logic/basic.lean Outdated Show resolved Hide resolved
@eric-wieser
Copy link
Member

bors r-

A couple tiny comments. You should wait for a full CI build probably too, this might break a proof somewhere.

@bors
Copy link

bors bot commented Mar 21, 2022

Canceled.

vihdzp and others added 2 commits March 21, 2022 17:39
@vihdzp @eric-wieser
Update src/logic/basic.lean
39cf28b 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@vihdzp
infer
f79f33c
@vihdzp
Copy link
Collaborator Author

vihdzp commented Mar 22, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 22, 2022
@vihdzp
feat(logic/basic): ulift.down is injective (#12824)
e51377f 
We also make the arguments to `plift.down_inj` inferred.
@bors
Copy link

bors bot commented Mar 22, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(logic/basic): ulift.down is injective [Merged by Bors] - feat(logic/basic): ulift.down is injective Mar 22, 2022
@bors bors bot closed this Mar 22, 2022
@bors bors bot deleted the down_inj branch March 22, 2022 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vihdzp @jcommelin @eric-wieser