Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(analysis/locally_convex/with_seminorms): use abbreviations to allow for dot notation #12846

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - refactor(analysis/locally_convex/with_seminorms): use abbreviations to allow for dot notation #12846

wants to merge 4 commits into from

Conversation

mcdoll
Copy link
Member

@mcdoll mcdoll commented Mar 20, 2022

For the boundedness lemmas I think it is not useful to do any refactors, because they have to be rewritten as soon we have bornological spaces.

Open in Gitpod

@mcdoll mcdoll added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Mar 20, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Mar 20, 2022
@mcdoll mcdoll mentioned this pull request Mar 20, 2022
Closed
3 tasks
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 21, 2022
@mcdoll mcdoll added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 21, 2022
jcommelin
jcommelin approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 21, 2022
bors bot pushed a commit that referenced this pull request Mar 21, 2022
@mcdoll
refactor(analysis/locally_convex/with_seminorms): use abbreviations t…
fd4a034 
…o allow for dot notation (#12846)
@bors
Copy link

bors bot commented Mar 21, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(analysis/locally_convex/with_seminorms): use abbreviations to allow for dot notation [Merged by Bors] - refactor(analysis/locally_convex/with_seminorms): use abbreviations to allow for dot notation Mar 21, 2022
@bors bors bot closed this Mar 21, 2022
@bors bors bot deleted the mcdoll/with_seminorms_refactor2 branch March 21, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcdoll @jcommelin @leanprover-community-bot-assistant