[Merged by Bors] - refactor(order/hom/complete_lattice): Fix the definition of frame_hom
#12855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
the
awaiting-review
eric-wieser
reviewed
Mar 21, 2022
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Mar 22, 2022
…m` (#12855) I misread "preserves finite meet" as "preserves binary meet", meaning that currently a `frame_hom` does not have to preserve `⊤` (subtly, preserving arbitrary join does not imply that either). This fixes my mistake.
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
frame_homframe_hom
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I misread "preserves finite meet" as "preserves binary meet", meaning that currently a
frame_homdoes not have to preserve⊤(subtly, preserving arbitrary join does not imply that either). This fixes my mistake.I had to change the extension path for
complete_lattice_hombecause two instances were not defeq (but they were defeq afterext). See Zulip