Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/category/Semilattice): The categories of semilattices #12890

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(order/category/Semilattice): The categories of semilattices #12890

wants to merge 3 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Mar 22, 2022 •
edited
Loading

Define SemilatticeSup and SemilatticeInf, the categories of finitary supremum lattices and finitary infimum lattices.

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Mar 22, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Mar 22, 2022
@leanprover-community-bot-assistant
Copy link
Collaborator

This PR/issue depends on:

b-mehta
b-mehta approved these changes Mar 28, 2022
View reviewed changes
Copy link
Collaborator

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments only. Do you also want the forgetful functors Lattice => SemilatticeT? And the commuting square to PartialOrder? (Can be TODO for another PR, but maybe mention it in the module doc here for now?)

src/order/category/Semilattice.lean Outdated Show resolved Hide resolved
src/order/category/Semilattice.lean Outdated Show resolved Hide resolved
src/order/category/Semilattice.lean Show resolved Hide resolved
src/order/category/Semilattice.lean Show resolved Hide resolved
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 29, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 29, 2022
@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 31, 2022
bors bot pushed a commit that referenced this pull request Mar 31, 2022
@YaelDillies
feat(order/category/Semilattice): The categories of semilattices (#12890
290f440 
)

Define `SemilatticeSup` and `SemilatticeInf`, the categories of finitary supremum lattices and finitary infimum lattices.
@bors
Copy link

bors bot commented Mar 31, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/category/Semilattice): The categories of semilattices [Merged by Bors] - feat(order/category/Semilattice): The categories of semilattices Mar 31, 2022
@bors bors bot closed this Mar 31, 2022
@bors bors bot deleted the Semilattice branch March 31, 2022 08:43
jjaassoonn pushed a commit that referenced this pull request Apr 7, 2022
@YaelDillies @jjaassoonn
feat(order/category/Semilattice): The categories of semilattices (#12890
621b4a5 
)

Define `SemilatticeSup` and `SemilatticeInf`, the categories of finitary supremum lattices and finitary infimum lattices.
jjaassoonn pushed a commit that referenced this pull request Apr 7, 2022
@YaelDillies @jjaassoonn
feat(order/category/Semilattice): The categories of semilattices (#12890
91a9d15 
)

Define `SemilatticeSup` and `SemilatticeInf`, the categories of finitary supremum lattices and finitary infimum lattices.
jjaassoonn pushed a commit that referenced this pull request Apr 7, 2022
@YaelDillies @jjaassoonn
feat(order/category/Semilattice): The categories of semilattices (#12890
b6b121a 
)

Define `SemilatticeSup` and `SemilatticeInf`, the categories of finitary supremum lattices and finitary infimum lattices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-mehta b-mehta b-mehta approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YaelDillies @leanprover-community-bot-assistant @semorrison @b-mehta