Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(data/list/basic): Remove many redundant hypotheses #12950

Closed
wants to merge 1 commit into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Mar 26, 2022

Many theorems about last required arguments proving that certain things were not equal to nil, when in fact this was always the case. These hypotheses have been removed and replaced with the corresponding proofs.


Open in Gitpod

@vihdzp vihdzp added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Mar 26, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Mar 26, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 26, 2022
bors bot pushed a commit that referenced this pull request Mar 26, 2022
Many theorems about `last` required arguments proving that certain things were not equal to `nil`, when in fact this was always the case. These hypotheses have been removed and replaced with the corresponding proofs.
@bors
Copy link

bors bot commented Mar 26, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(data/list/basic): Remove many redundant hypotheses [Merged by Bors] - refactor(data/list/basic): Remove many redundant hypotheses Mar 26, 2022
@bors bors bot closed this Mar 26, 2022
@bors bors bot deleted the last_cons branch March 26, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants