[Merged by Bors] - chore(algebra/group_power/lemmas): turn [zn]smul lemmas into instances
#13002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `mul_[zn]smul_assoc` was `←smul_mul_assoc` * `mul_[zn]smul_left` was `←mul_smul_comm`
1 task
eric-wieser
added
the
awaiting-review
eric-wieser
changed the title
[zs]mul lemmas
eric-wieser
changed the title
[zs]mul lemmas[zn]smul lemmas
eric-wieser
changed the title
[zn]smul lemmas[zn]smul lemmas into instances
leanprover-community-bot-assistant
added
ready-to-merge
|
bors r- Let's get this passing CI first! |
|
Canceled. |
|
Bors merge |
bors bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
…ces (#13002) This adds new instances such that: * `mul_[zn]smul_assoc` is `←smul_mul_assoc` * `mul_[zn]smul_left` is `←mul_smul_comm` This also makes `noncomm_ring` slightly smarter, and able to handle scalar actions by `nat`. Thanks to Christopher, this generalizes these instances to non-associative and non-unital rings. Co-authored-by: Christopher Hoskin <christopher.hoskin@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
…ces (#13002) This adds new instances such that: * `mul_[zn]smul_assoc` is `←smul_mul_assoc` * `mul_[zn]smul_left` is `←mul_smul_comm` This also makes `noncomm_ring` slightly smarter, and able to handle scalar actions by `nat`. Thanks to Christopher, this generalizes these instances to non-associative and non-unital rings. Co-authored-by: Christopher Hoskin <christopher.hoskin@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
[zn]smul lemmas into instances[zn]smul lemmas into instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new instances such that:
mul_[zn]smul_associs←smul_mul_assocmul_[zn]smul_leftis←mul_smul_commThis also makes
noncomm_ringslightly smarter, and able to handle scalar actions bynat.Thanks to Christopher, this generalizes these instances to non-associative and non-unital rings.
Co-authored-by: Christopher Hoskin christopher.hoskin@gmail.com