Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(algebra/big_operators) delete duplicates and change names #1301

Merged
merged 2 commits into from
Aug 5, 2019
Merged

refactor(algebra/big_operators) delete duplicates and change names #1301

merged 2 commits into from
Aug 5, 2019

Conversation

ChrisHughes24
Copy link
Member

@ChrisHughes24 ChrisHughes24 commented Aug 5, 2019 •
edited

sum_le_sum was just a less general version of sum_le_sum' so I delete it, as well as zero_le_sum and sum_le_zero. Also renaming sum_le_zero' to sum_nonpos and zero_le_sum' to sum_nonneg

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@ChrisHughes24 ChrisHughes24 requested a review from a team as a code owner August 5, 2019 13:08
@jcommelin jcommelin added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Aug 5, 2019
@mergify mergify bot merged commit de83205 into master Aug 5, 2019
@mergify mergify bot deleted the sum_nonneg branch August 5, 2019 15:02
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
@ChrisHughes24 @anrddh
refactor(algebra/big_operators) delete duplicates and change names (l…
c726236 
…eanprover-community#1301)

* refactor(algebra/big_operators) delete duplicates and change names

* fix build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChrisHughes24 @jcommelin